[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: do I need "ifdef HAVE_UNISTD_H" if I import unistd?

From: Eric Blake
Subject: Re: do I need "ifdef HAVE_UNISTD_H" if I import unistd?
Date: Mon, 16 May 2011 15:30:04 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10

On 05/16/2011 03:16 PM, Sam Steingold wrote:
>> * Eric Blake <address@hidden> [2011-05-16 14:13:29 -0600]:
>> Import that module, possibly add a cfg.mk counterpart (hmm, we
>> probably ought to provide a template file for that; but you can use
>> coreutils.git/cfg.mk for an idea of how it can be customized), use GNU
>> make, and run 'make syntax-check' to catch a number of consistency
>> errors.  If you decide that a particular syntax check is inappropriate
>> for your project, cfg.mk will let you omit it.
> it looks useful but _very_ hard to actually use.
> why is maint.mk put into my top dir?

Because that's where GNUmakefile looks for it.

> shouldn't it go to src/build-aux/?

Patches welcome, but for now, all projects using it have lived with it
in the top directory.

> why doesn't vc-list-files accept a list of directories?

Patches welcome; seems like a useful addition.

> (it would be 'src modules' for me)
> why is $(srcdir)/lib/ hard-coded? I use gllib instead of lib.

Where is it hard-coded?  We've been trying to get rid of hard-coded
aspects, but we can only fix things as they are pointed out.

> when I managed to get it "running", I got
> warnings about HAVE_ALLOCA_H in ChangeLog, aclocal.m4, and configure.

You can add per-file exemptions to particular rules, either via
top-level .x-sc files or via entries in cfg.mk (the latter being fewer
files to maintain).

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]