[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Misc. comments

From: Nicola Pero
Subject: Re: Misc. comments
Date: Mon, 15 Jan 2001 10:29:16 +0000 (GMT)

> - There's a bug in the menu title drawing that occurs when anything less
> than the entire title bar is redrawn. This patch seems to take care of
> it 

> (tell me if you have any preferred diff format):

diff -u

> Index: gui/Source/NSMenu.m
> ===================================================================
> RCS file: /gnustep/gnustep/core/gui/Source/NSMenu.m,v
> retrieving revision 1.77
> diff -r1.77 NSMenu.m
> 1378,1379c1378,1380
> <   
> <   PSmoveto(rect.origin.x + 7, rect.origin.y + 7);
> ---
> > 
> >   workRect=[self bounds];
> >   PSmoveto(workRect.origin.x + 7, workRect.origin.y + 7);

Thanks - nice fix - I'll apply it as soon as CVS is working again.

> - Scrolling an NSClipView messes up at times. Specifically, the copy
> won't work if the entire clipview isn't visible, and it won't work if
> the scroll delta isn't an integer. Related to this is a problem with
> snapping coordinates to integers in device space when scrolling (done in
> constrainScrollPoint:). E.g. coordinates in the clipview like (10,10)
> get converted to (9.5,9.5) in device space, snapped to (9,9), and
> converted back to (9.5,9.5). If you scroll in one direction, the other
> will slowly drift towards 0 due the repeated converting and snapping.

> Maybe it'd be better to separate 'real' scroll coordinates and drawing
> coordinates, so drawing coordinates could be kept to integers to make
> copying work, and the 'real' coordinates wouldn't move around from all
> the converting back and forth.

I'd really like to remove the hack which reduces the real coordinates to
integers in NSClipView - but if you try removing the code/hack, and then
try scrolling a table view or a text view, you see it gets immediately
terrible.  If you have patches or fixes, they are welcome of course.

If you are talking - instead - about the rubbish which is drawn sometimes
in scrollviews - like when you scroll a textview, then I think I fixed it
yesterday and it's a completely unrelated matter - I will commit the fix
to CVS as soon as CVS is working again.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]