[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: completing-read (and M-x) with pop-up-framesnon-nilchangesframefocus
From: |
Stefan Monnier |
Subject: |
Re: completing-read (and M-x) with pop-up-framesnon-nilchangesframefocus |
Date: |
Thu, 21 Jul 2005 14:25:32 -0400 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) |
> --- window.c 13 jui 2005 13:58:39 -0400 1.512
> +++ window.c 15 jui 2005 03:30:07 -0400
> @@ -3475,7 +3475,13 @@
> we need to create a new frame. */
> if (pop_up_frames || last_nonminibuf_frame == 0)
> {
> + Lisp_Object w = Fselected_window ();
> + struct gcpro gcpro1;
> + GCPRO1 (w);
> window = Fframe_selected_window (call0 (Vpop_up_frame_function));
> + if (Fwindow_live_p (w))
> + Fselect_window (w, Qt);
> + UNGCPRO;
> Fset_window_buffer (window, buffer, Qnil);
> return display_buffer_1 (window);
> }
> It looks plausible to me. I would expect it to have
> no effect when the mouse position controls window manager focus,
> and that is what it should do, but that needs to be tested.
> Could someone test that?
I've been using it here on GNU/Linux with a window-manager that does
focus-follows-mouse and haven't noticed any problem with it.
In reality this patch will have no effect whatsoever in most cases because
Vpop_up_frame_function usually doesn't change the selected window, so the
call to Fselect_window is a nop (the body exits early).
But I still have no idea whether it actually fixes the original problem
or not. Someone will have to check it,
Stefan
- RE: completing-read (and M-x) with pop-up-frames non-nil changes frame focus, (continued)
- Re: completing-read (and M-x) with pop-up-frames non-nil changes frame focus, Richard M. Stallman, 2005/07/18
- RE: completing-read (and M-x) with pop-up-frames non-nil changes framefocus, Drew Adams, 2005/07/18
- Re: completing-read (and M-x) with pop-up-frames non-nil changes framefocus, Richard M. Stallman, 2005/07/18
- RE: completing-read (and M-x) with pop-up-frames non-nil changesframefocus, Drew Adams, 2005/07/18
- Re: completing-read (and M-x) with pop-up-frames non-nil changesframefocus, Richard M. Stallman, 2005/07/19
- RE: completing-read (and M-x) with pop-up-frames non-nilchangesframefocus, Drew Adams, 2005/07/19
- Re: completing-read (and M-x) with pop-up-frames non-nilchangesframefocus, Richard M. Stallman, 2005/07/20
- RE: completing-read (and M-x) with pop-up-framesnon-nilchangesframefocus, Drew Adams, 2005/07/20
- Re: completing-read (and M-x) with pop-up-framesnon-nilchangesframefocus, Richard M. Stallman, 2005/07/21
- Re: completing-read (and M-x) with pop-up-framesnon-nilchangesframefocus,
Stefan Monnier <=
- Re: completing-read (and M-x) with pop-up-frames non-nilchangesframefocus, Henrik Enberg, 2005/07/20
- Re: completing-read (and M-x) with pop-up-frames non-nilchangesframefocus, Jan D., 2005/07/20