[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Towards a cleaner build: rmailmm

From: Stefan Monnier
Subject: Re: Towards a cleaner build: rmailmm
Date: Thu, 13 Jun 2019 18:15:31 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> In rmail-mime-insert-bulk:
> mail/rmailmm.el:839:21:Warning: `string-as-unibyte' is an obsolete function
>     (as of 26.1); use `encode-coding-string'.
> I've stared at the code some, but I'm not totally sure what it's doing
> here.

Yeah, I looked at the history and that didn't enlighten me either (it
was introduced in 2e9075d3968a2542d47b7e64a1e457711568373d, i.e. soon
after the release of Emacs-23.1 where the internal encoding
changed to utf-8 and Rmail changed from babyl to mbox format).

> But...  wouldn't string-to-unibyte be the right thing here anyway?

I'd tend to agree.  string-as-unibyte ends up basically encoding with
`utf-8-emacs-unix` coding-system which seems like an odd choice here.

> I'm not an rmail user, so I can't test this.

Neither am I.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]