Hi again:
I was just checking the code once again and it is actually working. The
problem before was in the lisp part. the interactive functions:
(set-face-extend 'region t)
does not change the face value when called interactively. (We have
observed similar issues before with customize-variable and maybe it
needs to be fix.) They seem to be changing the values of the variables
locally in the minibuffer instead of the "caller" buffer. But it works
when executed throw C-x C-e; so maybe some lisper can give a look to
this please.
As now it works at least for the region and fixes these issues.
1) Tui and gui extension is consistent (still needs some work but should
be a minor issues to fix)
2) the region extension can be customized (which could be considered a
new feature).
3) The interaction with dfci reported in the bug that started this is
not broken anymore.
At the end I implemented it lazily because it appeared to be the easiest
alternative for me; but I am completely open to any comment/suggestion
(please ignore code style for now.)
Finally I have a explicit question:
when we set :extend nil for the region face do you consider correct that
the extra space we always add must have the region color (instead of the
default) in order to see
a colored space in the empty lines?
-----Original Message-----
From: martin rudalics <address@hidden>
To: Ergus <address@hidden>
Cc: Eli Zaretskii <address@hidden>; emacs-devel <address@hidden>
Sent: Wed, Sep 4, 2019 10:34 pm
Subject: Re: Question about display engine
> I have just uploaded some changes but the functionality is still not
> working.
>
> I separated the changes in 3 commits and in the last one are only the
> ones I made in the xdisp.c (the ones that need to be checked, because
> the rest is only infrastructure.)
>
> see the master branch in:
https://github.com/Ergus/EmacsPlease send a patch for current master. Otherwise I have no idea how
to compare your changes.
Thanks, martin