[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: BIKESHED: completion faces

From: Dmitry Gutov
Subject: Re: BIKESHED: completion faces
Date: Wed, 6 Nov 2019 18:01:50 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

On 06.11.2019 17:48, João Távora wrote:
On Wed, Nov 6, 2019 at 3:43 PM Dmitry Gutov <address@hidden <mailto:address@hidden>> wrote:

    On 06.11.2019 17:31, João Távora wrote:
     > Really, you think the patch below is "convoluted"?


    Not the number of lines, but the essence: renaming faces, as well as
    swapping them in certain conditions.

It's not "in certain conditions". There is not a single "if" in my patch.
It's totally linear.

You don't have to mention "if" in a diff to introduce different behaviors.

In one function you replace completions-common-part with completions-secondary-emphasis (its new alias). In another function, you replace it with completions-emphasis.

And a similar thing with the other face.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]