emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: VOTE: Changing completions-common-part face's default


From: Stefan Monnier
Subject: Re: VOTE: Changing completions-common-part face's default
Date: Fri, 08 Nov 2019 16:42:50 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> Please tell which face will use this, whether as foreground or as
> background color, and what will that face highlight in various
> completion scenarios.  (I think I know the answers, but I'm so
> flabbergasted by the other thread that I no longer believe my memory
> and my ability to draw conclusions from what you mentioned in this
> one.  Sorry.)

Concretely the patch I'm suggesting is the one below, which makes it so
the "common-part" (e.g. the common prefix in the case basic completion)
of the completions has a blue3 foreground rather than being identical to
`default` (we'd also want to find a color for the dark background case,
but... one step at a time).


        Stefan


diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index 43dd277a2e..e4c4edd114 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -1687,7 +1687,9 @@ completions-first-difference
   "Face for the first character after point in completions.
 See also the face `completions-common-part'.")
 
-(defface completions-common-part '((t nil))
+(defface completions-common-part
+  '((((background light)) :foreground "blue3")
+    (t nil))
   "Face for the parts of completions which matched the pattern.
 See also the face `completions-first-difference'.")
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]