[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: VOTE: Changing completions-common-part face's default

From: Stefan Monnier
Subject: Re: VOTE: Changing completions-common-part face's default
Date: Sat, 09 Nov 2019 10:25:52 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> Hm... so the "common part" will be highlighted as blueish and the
> "first difference" will stay just bold?


> Does that look good?

I'll pass judgment on aesthetics.

It doesn't make the "first-difference" less legible IMO, and it does
make the "common-part" easier to find, which are my main criteria, so it
does look good in this sense.  I'm not trying to find a perfect
solution, just an incremental improvement.

> IOW, will the bold character be seen right next to a blue one?


> Maybe we should also change the default definition of the
> first-difference face?

I'd rather postpone this decision to later.

> I'd actually expect this face to use the background, because that's
> how other applications behave, and I thought this change was motivated
> by that?

While highlighting the "common-part" is definitely standard, there's
definitely not a standard *way* to highlight it.  While a background
color is used in some cases I have the vague impression that it might be
a minority rather than a majority of cases.

> Also, what will this do to the output of the more aggressive
> completion styles?

For flex's "foo matched to frobot" it highlights the "f" the "o"s in
blue3 and the "t" in bold.

>> we'd also want to find a color for the dark background case,
> Right.

But I'd also rather postpone this decision to later.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]