emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [External] : Re: [PATCH] When deleting in bookmark menu, prompt for


From: Matthias Meulien
Subject: Re: [External] : Re: [PATCH] When deleting in bookmark menu, prompt for confirmation.
Date: Sat, 08 May 2021 22:46:00 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Drew Adams <drew.adams@oracle.com> writes:

> [IIRC, vanilla bookmark.el doesn't have a way to
> switch to a different bookmark file interactively.
> All it needs to do, to add that, is to let a prefix
> arg for `bookmark-load' and `bookmark-bmenu-load'
> provide non-nil arg OVERWRITE.  It provides a
> prefix arg for saving, but not for loading.]

I checked the implementation of `bookmark-bmenu-load' and
`bookmark-load' and learned that this is already implemented: One can
C-u l from a bookmark menu buffer to load bookmarks destructively and
change the path of the default bookmark file!

Should the docstring of `bookmark-bmenu-load' should be extended as
follows to make this feature easier to discover?

diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index 64b467adfa..766ddc8402 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -2063,7 +2063,10 @@ bookmark-bmenu-save
 
 
 (defun bookmark-bmenu-load ()
-  "Load the bookmark file and rebuild the bookmark menu-buffer."
+  "Load the bookmark file and rebuild the bookmark menu-buffer.
+With a prefix arg, existing bookmarks are destroyed and the
+loaded bookmark file is watched.
+"
   (interactive nil bookmark-bmenu-mode)
   (bookmark-bmenu-ensure-position)
   (save-excursion

-- 
Matthias



reply via email to

[Prev in Thread] Current Thread [Next in Thread]