[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [External] : Re: [PATCH] When deleting in bookmark menu, prompt for

From: Karl Fogel
Subject: Re: [External] : Re: [PATCH] When deleting in bookmark menu, prompt for confirmation.
Date: Wed, 26 May 2021 14:33:44 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

On 26 May 2021, Eli Zaretskii wrote:
From: Karl Fogel <kfogel@red-bean.com>
Cc: orontee@gmail.com,  drew.adams@oracle.com,  larsi@gnus.org,
  monnier@iro.umontreal.ca,  emacs-devel@gnu.org
Date: Tue, 25 May 2021 15:24:44 -0500

>Given what you wrote, and what bookmark-load does with the >prefix
>argument, I think it is better to say that explicitly in
>bookmark-bmenu-load's doc string, since you only need a single >quite >simple sentence to say that, whereas the doc strong of >bookmark-load
>is quite long.

Well, now that I've done it, I think your way is an improvement -- although it turned out to be slightly more doc change than I expected. Revised patch attached for review.

LGTM, thanks.

Thanks for the review, Eli.  Committed (c4e8d1dbe2e) on master.

The reason it's 'master' instead of 'emacs-27' is that the patch doesn't apply cleanly on 'emacs-27', and the effort needed to adjust it didn't seem worth it to me. (If these documentation updates were urgently needed by users, I'd make a different decision, but I don't think that's the case.)

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]