Re: Select completions from the minibuffer

[Ergus]

Hi:

Now there is a variable completions-highlight-face. When nil highlight
is disabled, otherwise it must be a the face to use, by default
completions-highlight.

I had the mode before because I needed some initialization, but with the
cursor-face feature that is not needed and the code got simpler.

If anyone knows how to modify redisplay--update-cursor-face-highlight to
enable cursor-face to accept cons and plists (as the documentation of
mouse-face indicates it should) please just add it there.

On Mon, Mar 14, 2022 at 10:41:56AM +0200, Juri Linkov wrote:
> > > `M-<up>' in bug#49931 let-binds the new user option,
> > > so it could let-bind completions-highlight-mode as well.
> >
> > Yes.
>
> Alas, after the last commit c1ea52f4ad in the feature/completions-customs branch
> this is not possible anymore.
>
> Before this commit we were able to let-bind
> `cursor-face-highlight-mode' in the new command:
>
> ```
> (defun minibuffer-previous-completion (&optional n)
>  "Run `previous-completion' from the minibuffer in its completions window."
>  (interactive "p")
>  (with-minibuffer-completions-window
>    (let ((cursor-face-highlight-mode t))
>      (previous-completion n))))
> ```
>
> because 'redisplay--update-cursor-face-highlight' was always
> presented in `pre-redisplay-functions', and the mode was checked with
>
>  (when cursor-face-highlight-mode
>
> But now the hook is added only when mode is enabled.

And it is always added to completions during the setup when
completions-highlight-face is non-nil.