emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Call for volunteers: add tree-sitter support to major modes


From: Theodor Thornhill
Subject: Re: Call for volunteers: add tree-sitter support to major modes
Date: Tue, 11 Oct 2022 09:13:13 +0200

Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:

> If someone has typescript-mode installed from MELPA and upgrade to 
> Emacs-29... Which typescript-mode are they going to be running?
>
> Emacs does not support namespaces, so there would be no way to separate 
> those two. And if the MELPA version runs, it would shadow the Emacs29 
> implementation.
>
> Since I believe in keeping things simple for users, I think another 
> option we could consider would be to simply make typescript-mode (the 
> plain elisp version hosted on MELPA) simply not register itself if it 
> finds that the tree-sitter version is already available from Emacs. And 
> then we could stop updating it, and people would eventually stop 
> installing it.
>
> Speaking as one of the MELPA typescript-mode co-maintainers, I have 
> absolutely zero plans for maintaining the old elisp-based version once a 
> better, tree-sitter version has been mainlined into Emacs itself.
>
> --
>

Yeah, agreed.  Though the new in-tree one could be renamed to tsx-mode.
That will support both typescript and tsx, anyways.  Or it could be made
to not work on 29.1, hehe.  I don't really have a strong opinion, but
seeing the state of the current typescript-mode, I do think there's a
case here for actually superseding it.  But that's not really my call to
be made. 

_I_ think the best name here is typescript-mode, but it could be
tsx-mode, typescript-tree-sitter-mode or anything else.

How about deprecating typescript.el the moment the 29.1 branch is cut?
After we can but some sort of structure in place for the two to coexist?

Theo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]