emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 55eabe96c9: ; Improve manual for Tramp kubernetes method


From: Filipp Gunbin
Subject: Re: master 55eabe96c9: ; Improve manual for Tramp kubernetes method
Date: Tue, 25 Oct 2022 23:14:47 +0300
User-agent: Gnus/5.13 (Gnus v5.13)

Hi Michael,

I've tested your patch a bit more.  Good news is that strange completion
behavior ("2" displayed when actually no completions) is gone, perhaps
recent "make bootstrap" helped.

The problem with cache (not) clearing remains, although with
tramp-completion-use-cache nil it doesn't show.  I've opened bug#58782
for that.

Nitpicks:

+(defun tramp-kubernetes--current-context-data (vec)
+  "Return Kubernetes current context data as JSONPATH string."

The result is just json, not jsonpath (jsonpath is an expression
language).

-  ;; `tramp-maybe-open-connection', it will be caught there.
+  ;; `tramp-maybe-open-connection', it will be caught there.  The same
+  ;; check will be applied with the function kept in`tramp-config-check'.
                                                     ^
Space missing.

Thank you again,
Filipp



reply via email to

[Prev in Thread] Current Thread [Next in Thread]