[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: feature/package-vc has been merged

From: Rudolf Adamkovič
Subject: Re: feature/package-vc has been merged
Date: Sat, 12 Nov 2022 01:32:09 +0100

Philip Kaludercic <philipk@posteo.net> writes:

> (sorry, this message got sent out too early.  Continuing my reply
> here)

Gotcha!  Replying to both messages here.

>>    M-x package-vc-refresh
> As we seem to use package.el in different ways, can you clarify what
> your intention is when invoking `package-vc-refresh'?

I wanted to see what it does with empty `package-vc-selected-packages'.

Yeah, I know.  A strange "first thing one does".  :)

> The documentation string tries to clarify what is does, but perhaps
> the name is confusing:
>       "Refresh the installation for package given by PKG-DESC.
>     Refreshing an installation means scraping for new autoload
>     cookies, re-compiling Emacs Lisp files, building and installing
>     any documentation, downloading any missing dependencies.  This
>     command does not fetch new revisions from a remote server.  That
>     is the responsibility of `package-vc-update'.  Interactively,
>     prompt for the name of the package to refresh."
> Reload?  Regenerate?  Redo?

So good!  The documentation before said that it refreshes the given
package.  Hence, I kept scratching my head.  Now, it all makes sense.

As for the name, how about rebuild?  All those steps normally happen
during a build process.  I think "refresh" sounds much too close to

>>    Oh, the list!  Change the configuration again:
>>      (with-eval-after-load 'package-vc
>>        (add-to-list 'package-vc-selected-packages '(modus-themes)))
>>    Restart Emacs.
> Two ways to resolve this: Either throw an error earlier, which might
> be annoying but the right thing™, or dwim and accept that the value
> might not be readable in ECI.

Early or late, we need to show at least the traditional Emacs type
predicate error.  I say that because it took me ten minutes to find the
problem. :)

> This issue should be resolved with the above patch, but the question
> still remains what went wrong in the above installation.  Can you
> check/post the -pkg.el and -autoloads.el file?

Oops, I since then restored everything back.

No worries though, I will do more testing going forward!

> package-vc.el (just like package.el) doesn't treat MELPA packages as
> special or different.  If you give `package-vc-install' a URL, it will
> try to guess what has to be done -- this doesn't always work, but the
> guessing can still be improved.
> What you can do with `package-vc-selected-packages' is give your own
> ELPA-esque specification.  That should work most of the time if a
> package is not available on GNU ELPA or NonGNU ELPA.

I see.  Smart!

> Did the above [`package-vc-refresh'] docstring clarify that point?


>> I could not find `package-vc-update-all' akin `package-update-all'.
>> Not that I needed it, but I looked for it in the case I manage to
>> install more packages.
> It doesn't exist.  My idea was that package-update-all would handle
> that, but there might be a value in a command that only updates source
> packages?

I think that would make sense.

>> The `package-vc-selected-packages' documentation [...]
> As mentioned above there are a few commits I haven't been able to push
> because emacs.git is preventing me from force pushing.  I'll try to
> get them up there some other way, and then rewrite the history before
> rebasing the changes onto master.

So much for "scratch" branches. :-/

"Be especially critical of any statement following the word
-- Anna Pell Wheeler, 1883-1966

Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava

reply via email to

[Prev in Thread] Current Thread [Next in Thread]