|
From: | Dmitry Gutov |
Subject: | Re: emacs-29 44ebd9cbd56 2/2: Eglot: explain how to update Eglot in manual (bug#62720) |
Date: | Thu, 4 May 2023 01:48:23 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 |
On 28/04/2023 03:35, João Távora wrote:
On Fri, Apr 28, 2023 at 12:53 AM Dmitry Gutov<dmitry@gutov.dev> wrote:Hi! On 28/04/2023 02:39, João Távora wrote:* lisp/progmodes/eglot.el (eglot-update): New command.Should it be called eglot-upgrade now as well?No objection, don't feel strongly about it. If you want to change it, go ahead, but remember to change the manual as well.
Ok, I did the rename. Two more things:- Commit 44ebd9cbd56 also removed the call to (eldoc) from the end of eglot-completion-at-point which has been there for a few years. Was that intentional? Didn't look like it.
- Consider the issue that I brought up in https://debbugs.gnu.org/62720#715 regarding (cadr (assoc 'eglot package-archive-contents)). I'm not sure there's even a guarantee that the available versions are sorted, but even if they are obeying package-archive-priorities seems like a good idea. Though I can understand if it's not your first priority in this command.
[Prev in Thread] | Current Thread | [Next in Thread] |