Re: [ELPA] New package: dict

[Eshel Yaron]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Eshel Yaron <me@eshelyaron.com>
>> Cc: philipk@posteo.net,  emacs-devel@gnu.org
>> Date: Thu, 18 May 2023 15:21:31 +0300
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> >> --8<---------------cut here---------------start------------->8---
>> >> (setq dictionary-read-dictionary-function
>> >>       #'dictionary-completing-read-dictionary)
>> >> (setq dictionary-read-word-function
>> >>       #'dictionary-completing-read-word)
>> >> (setq dictionary-display-definition-function
>> >>       #'dictionary-display-definition-in-help-buffer)
>> >> --8<---------------cut here---------------end--------------->8---
>> >
>> > This looks excessive.  How about adding yet another defcustom, with a
>> > :set function, which will make all these adjustments for users who
>> > want the words displayed in *Help*?
>> 
>> I agree setting three options may be a bit much for casual users, but
>> note that in order to display word definitions in *Help* you only need
>> to customize the last option, `dictionary-display-definition-function`.
>> The other two only affect the interactive word and dictionary selection
>> (mostly adding completion), so I'm not sure it's necessary to couple
>> them with how the definition ends up being presented.
>
> Then why did you add the other options?

I've added these options in the patch because I want to have minibuffer
completions in `dictionary-search`'s prompts, similarly to
`dict-describe-word`.  That's also why I mentioned all three
customizations in my earlier message: to show how to obtain the behavior
of `dict-describe-word` in dictionary.el using the new user options.

But from the perspective of other dictionary.el users, it may be useful
to customize each of the options but not the necessarily all of them.
That's why I implemented them as separate user options.  Makes sense?


-- 
Best,

Eshel