emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Excessive use of `eassert`


From: Eli Zaretskii
Subject: Re: Excessive use of `eassert`
Date: Fri, 19 Jan 2024 21:56:10 +0200

> Date: Fri, 19 Jan 2024 19:42:39 +0000
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
>  Paul Eggert <eggert@cs.ucla.edu>, emacs-devel@gnu.org
> From: Alan Mackenzie <acm@muc.de>
> 
> > > Why do you find this specific assertion important?  When building other
> > > `Lisp_Object`s (like `make_fixnum`) we don't seem to have any
> > > corresponding assertion that the revere operation (e.g. XFIXNUM) returns
> > > the original value.
> 
> > make_fixnum is a trivial bit-shuffling, whereas make_lisp_symbol is
> > much trickier.  Perhaps especially so now that we have
> > symbols-with-positions as well as bare symbols.
> 
> Not really.  Symbols with positions don't belong in the obarray.  If they
> somehow get there, then that's a bug to be fixed.

Does that mean you'd like the assertion to be left there, or does that
mean you don't care if it were removed?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]