emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Excessive use of `eassert`


From: Eli Zaretskii
Subject: Re: Excessive use of `eassert`
Date: Fri, 19 Jan 2024 18:23:06 +0200

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Paul Eggert <eggert@cs.ucla.edu>,  Alan Mackenzie <acm@muc.de>,
>   emacs-devel@gnu.org
> Date: Fri, 19 Jan 2024 10:50:51 -0500
> 
> > since 2016.  I use an Emacs build with ENABLE_CHECKING and without
> > optimizations every day, and while it is indeed slower than the
> > production build by a factor of 3.5, it is not unbearably slow.
> 
> Same here.  I can't vouch for 3.5 specifically, but 3-4 sounds about
> right for me as well.  Tho I'll also note that (many) years ago
> the slowdown was lower, more in the 2x ballpark.

It's possible that GCC optimizes better nowadays.  Also, back then we
had macros, not inline functions that sometimes aren't inlined.

> In any case, I'm not insisting.

Neither am I.

> I already removed that assertion from
> my local branch, which is the one that affects me.  My messages was
> mostly intended to share my discovery/surprise: I always assumed that
> something like `Qnil` in the source would turn into some kind of
> constant in the machine code (possibly modulo relocation), regardless of
> ENABLE_CHECKING.

Let's see what Paul and Alan think.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]