Re: [Gnash-commit] gnash libbase/tu_config.h libbase/jpeg.cpp serv...

[strk]

On Wed, May 02, 2007 at 01:42:51PM +0100, Martin Guy wrote:
> More usefully:
> 
> I remember discovering that compilation without jpeg-dev didn't work,
> so we made it mandatory during configuration instead of optional that
> doesn't work if it's not enabled.
> 
> That said, both --disable-jpeg and --without-jpeg both still seem to
> exist as configure flags, so you can try building it with one or the
> other. If it works, you cn make the code hacks to dike out use of
> jpeg.

Ok, thanks for the info.

> Personally I'm aiming at a flash player, and flash movies contain
> jpegs so I don't see this as a proprity. Maybe after 0.8.0 when we go
> for size/speed optimisation, if we have a lot of spare time and
> nothing to do.

Granted.

> Meta-discussion: do you have to comment on everything anyone does, or
> can you let other people work and make decisions?
> I mean, I don't think your commits are that great quality either but I
> let you get on with it so that you can work better and make progress.

I appreciate your work, and I'm just trying to point out things that I think
we should be considering. I'd appreciate others doing the same with my own
commits and I've always reacted to other comments on my commits taking
them as precious. I can try to avoid replying to your commit logs, or just
avoid to add you in Cc, but please don't keep your constructive criticism
on my own commits to yourself. 

--strk;