[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash libbase/tu_config.h libbase/jpeg.cpp serv...

From: Rob Savoye
Subject: Re: [Gnash-commit] gnash libbase/tu_config.h libbase/jpeg.cpp serv...
Date: Wed, 02 May 2007 08:28:35 -0600
User-agent: Thunderbird (X11/20070326)

strk wrote:
> On Wed, May 02, 2007 at 01:42:51PM +0100, Martin Guy wrote:

>> That said, both --disable-jpeg and --without-jpeg both still seem to
>> exist as configure flags, so you can try building it with one or the

  These actually don't do anything... They need to set a define for the
code. I'd have renamed the existing JPEG define to be something more
sensible, and then added the AC_DEFINE to configure as a --disable-jpeg.

> I appreciate your work, and I'm just trying to point out things that I think
> we should be considering. I'd appreciate others doing the same with my own
> commits and I've always reacted to other comments on my commits taking
> them as precious. I can try to avoid replying to your commit logs, or just

  I actually appreciate this kind of discussion on this list. Unlike a
commercial project with formal code reviews, reading and discussion
things like this is is all we got. I've never known a free software
project to be any different. It can take a think skin to be a free
software developer sometimes...

  So I think we should all feel free to comment on commits, and I think
we shouldn't bitch about other people's comments unless they get rude or
personal attacks. It's often these discussions where we see how the code
we've developed in isolation has to work with other people's code.

        - rob -

reply via email to

[Prev in Thread] Current Thread [Next in Thread]