[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Failure to embed core.img is fatal now

From: Pavel Roskin
Subject: Re: Failure to embed core.img is fatal now
Date: Thu, 26 Jun 2008 10:48:13 -0400

On Thu, 2008-06-26 at 16:20 +0200, Robert Millan wrote:
> On Wed, Jun 25, 2008 at 05:48:34PM -0400, Pavel Roskin wrote:
> > 
> > I'm also surprised that the code alternately uses dir and
> > DEFAULT_DIRECTORY to calculate core_path.  core_path is calculated 3
> > times in one function!  If dir and DEFAULT_DIRECTORY are used correctly,
> > I suggest that two different variables are used for what is now called
> > core_path.
> Might be a remnant from when grub-setup mangled prefix?  I recently moved
> this off grub-setup and into grub-install/grub-mkimage so that core.img had
> the right prefix regardless on whether it was being loaded directly by a
> multiboot loader or via grub-setup.

No, it's all old code, traced to years 2003-2004.  But it needs to be
handled better because we need to move things around at this point.  If
nothing else, it will make the code more readable and less prone to

> Or maybe I'm completely out of context here.  In any case, please take into
> account that modifications done to core.img by grub-setup have no effect if
> core.img is being loaded directly.

I know.  That's why they are only written to disk if core.img is not

Anyway, I think there is a much simpler approach.  Changes to the memory
image of core.img should be applied after the image is tested for
readability.  Until then, they should be in temporary variables.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]