[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Emacs interface for Guix

From: Ludovic Courtès
Subject: Re: [PATCH] Emacs interface for Guix
Date: Sat, 16 Aug 2014 11:27:19 +0200
User-agent: Gnus/5.130011 (Ma Gnus v0.11) Emacs/24.3 (gnu/linux)

Alex Kost <address@hidden> skribis:

> (define* (manifest-show-transaction manifest transaction #:key dry-run?)
>   "Display what will/would be installed/removed from MANIFEST by TRANSACTION."


>          (format (current-error-port)
>                  (N_ "The following package ~:[will~;would~] be 
> ~a:~%~{~a~%~}~%"
>                      "The following packages ~:[will~;would~] be 
> ~a:~%~{~a~%~}~%"
>                      len)
>                  dry-run? action-string package-strings)))


>     (display-entries upgrade "upgraded (removed)")
>     (display-entries install "installed")
>     (display-entries remove "removed")))

Computed strings like impede correct internationalization.  The whole
sentences must be kept intact, to make sure people can translate them
correctly.  So that means repeating things a bit, but that’s

> I tried to avoid the code duplicating, so it became more compact and
> perhaps less readable.  Also I added reporting about the packages to
> upgrade: I thought as they are going to be replaced by the packages to
> install, it is ok to add “(removed)” there.  So an output should look
> like this (assuming "file-5.17" and "guile-2.0.9" are installed and are
> being upgraded):
> The following packages will be upgraded (removed):
>    file-5.17  out     /gnu/store/...
>    guile-2.0.9        out     /gnu/store/...
> The following packages will be installed:
>    file-5.18  out
>    guile-2.0.11       out

Ideally, I would just like to see:

 The following packages will be upgraded:
    file-5.17   out     /gnu/store/...
    guile-2.0.9 out     /gnu/store/...

and not see them listed under “will be installed.”

I would just keep the current messages for this patch series, and come
up with an improved message format in a separate patch.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]