Re: Process for reviewing patches as someone without commit access

[Felix Lechner]

Hi Chris,

On Wed, Sep 6, 2023 at 11:39 AM Christopher Baines <mail@cbaines.net> wrote:
>
> I don't want to make reviewing changes more difficult, and I think
> setting up more people with commit access and continuing the trend that
> it's mostly people with commit access that review changes would increase
> the difficulty, compared to what I'm proposing here, which is trying to
> empower people who just do review whilst avoiding any of the complexity
> of merging and pushing the changes without breaking things.

Usually, helpful reviews come from people with more experience. In
your system they come from folks with less. That seems upside down to
me.

More significantly, work gets done faster when people are motivated. A
junior committer who is about to push a change will be much more eager
to find an experienced reviewer. It's a way to demonstrate knowledge.
The reviewer's testimony will eventually help the contributor attain a
higher level.

In other words, there is no empowerment in "just do[ing] a review".

Kind regards
Felix