[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Process for reviewing patches as someone without commit access
From: |
Simon Tournier |
Subject: |
Re: Process for reviewing patches as someone without commit access |
Date: |
Thu, 07 Sep 2023 01:59:33 +0200 |
Hi Chris, all,
On Wed, 06 Sep 2023 at 16:55, Christopher Baines <mail@cbaines.net> wrote:
> Once we know what tags to use, I can have the QA frontpage do something
> similar to the "Mark as moreinfo" links, so it's easy to just click a
> button then send the email to change the state of a issue.
That’s cool!
Well, using emacs-debbugs and then
C-u M-x debbugs-gnu-usertags guix-patches RET
the list of usertags is:
guix-patches for-core-updates
guix-patches reviewed-looks-good
And if instead of guix-patches we consider guix then it reads,
guix build-system
guix cross-compilation
guix for-core-updates
guix looks-good
guix patch
guix plz-work
guix powerpc64le-linux
guix ready-to-review
guix reproducibility
guix reviewed
guix reviewed-looks-good
guix test-tag
guix v1.3.0
However, I do not know how to list all the bugs for the package
guix-patches that matches the usertag reviewed-looks-good. Anyway!
I think that the usertag ’reviewed’ is a good idea. That would be a
very good start. Then if it helps, we could add other usertags as
reviewed-julia for patches that the Julia team can merge.
Discussing about idea, would it be possible that the QA infrastructure
automatically send a message to Debbugs for tagging? For example, the
usertag ’qa-ok’ or whatever other meaningful name. :-)
Well, we can start with one usertag for only the architecture x86_64.
If this one is green, then it is worth to start the review. It would
help for filtering.
The slippery slope is to have too much usertags. I think we should
start with one or two usertags and see if it helps.
WDYT?
Cheers,
simon
Re: Process for reviewing patches as someone without commit access, Christopher Baines, 2023/09/27