[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in bui
From: |
Simon Tournier |
Subject: |
Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts) |
Date: |
Thu, 14 Sep 2023 19:28:06 +0200 |
Hi,
On Thu, 14 Sept 2023 at 18:51, Ludovic Courtès <ludo@gnu.org> wrote:
> For the record, that’s a 6% increase:
>
> --8<---------------cut here---------------start------------->8---
> $ guix size guix | tail -1
> total: 633.0 MiB
> $ guix size guix git-minimal | tail -1
> total: 675.7 MiB
> --8<---------------cut here---------------end--------------->8---
>
> (Of course it all adds up; I’m not saying we can dismiss it.)
>
> In the context of <https://issues.guix.gnu.org/65866> plus the lack of
> GC in libgit2 discussed in <https://issues.guix.gnu.org/65720>, my
> inclination is to include that hard dependency on Git.
And considering bug#65924 [1], it is not 6% but more. Because
currently git-minimal is broken and coreutils and potentially
util-linux would also be part of the closure.
--8<---------------cut here---------------start------------->8---
$ guix size guix | tail -1
total: 633.0 MiB
$ guix size guix git-minimal coreutils | tail -1
total: 692.7 MiB
$ guix size guix git-minimal coreutils util-linux | tail -1
total: 706.6 MiB
--8<---------------cut here---------------end--------------->8---
Therefore. it is 9.4% or worse 11.6%.
1: bug#65924: git searches coreutils and util-linux commands in PATH
Maxim Cournoyer <maxim.cournoyer@gmail.com>
Wed, 13 Sep 2023 14:00:09 -0400
id:87fs3iuf6e.fsf@gmail.com
https://yhetil.org/guix/87fs3iuf6e.fsf@gmail.com
https://issues.guix.gnu.org/msgid/87fs3iuf6e.fsf@gmail.com
> That’s not a happy choice for me, but it has the advantage of solving
> two immediate problems.
Three. :-)
Once git-minimal and plumbing Git commands around, some slow
procedures using libgit2 will be replaced by faster ones. And I also
have in mind some Git repository normalization that differs from SWH;
having plain Git commands would also easy that part.
Just to point that the introduction of git-minimal as hard dependency
of Guix means that libgit2 will be slowly removed from the picture,
IMHO.
Cheers,
simon
- Re: comparing commit-relation using Scheme+libgit2 vs shellout plumbing Git, (continued)
Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts), Simon Tournier, 2023/09/11
Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts), Maxim Cournoyer, 2023/09/11
Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts), Ludovic Courtès, 2023/09/14
- Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts),
Simon Tournier <=
- Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts), Maxim Cournoyer, 2023/09/16
- Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts), Ludovic Courtès, 2023/09/18
- Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts), Simon Tournier, 2023/09/18
- Re: bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts, Ludovic Courtès, 2023/09/19
- Re: bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts, Simon Tournier, 2023/09/19
Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts), Vagrant Cascadian, 2023/09/11