[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix 1456 (issue3693042)

From: Carl . D . Sorensen
Subject: Re: Fix 1456 (issue3693042)
Date: Mon, 20 Dec 2010 05:49:39 +0000

Thanks for the review, Patrick.

I've made the changes and posted a new patch set.
File Documentation/notation/rhythms.itely (right):
Documentation/notation/rhythms.itely:1111: c8^\markup "Beamed (2 2)"
\repeat unfold 7 { c8 } |
On 2010/12/20 01:20:30, pkx166h wrote:
c8^ \markup { "Beamed (2 2)" } as per CG also I'd personally put the
\repeat on
a new line.

Documentation/notation/rhythms.itely:1119: c8^\markup "Beamed (3 1)"
\repeat unfold 7 { c8 } |
On 2010/12/20 01:20:30, pkx166h wrote:
Same as above.

Documentation/notation/rhythms.itely:1172: #'()
  % beamExceptions
On 2010/12/20 01:20:30, pkx166h wrote:
The spacing here with the comments after each #'() construct is
with the example above.

Actually, I think the spacing is consistent.  They are farther to the
right because the indentation level is higher for those lines, due to
the addition of the StaffGroup and the Staff.

But I guess they don't need to be that far to the right.  They were that
far to the right because they originally had an unnecessary
beamExceptions rule.  I'll squeeze them all in.  It will look better.
Documentation/notation/rhythms.itely:1175: }
On 2010/12/20 01:20:30, pkx166h wrote:
This brace needs one more space by the looks of it

Nice catch!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]