Re: Remove special case in staff-spacing (issue4188051)

[Janek Warchoł]

Keith,

sorry for the delayed answer, i had to sort out my repository because
of grand-fixccing, and didn't know how to open eps files that are
created by regtests (eventually i compiled a few suspicious regtests
by hand).
In general, your patch is wonderful!  It does the things i hoped for for ages :)
However, a very close examination of regression tests showed two
regtests that might have undesirable differencies:
note-head-chord,
predefined-fretboards-transpose.
I also see some differencies in logs of several tests, for example
tablature-full-notation, but they don't look very serious...  I don't
have any idea why they appeared at all.
I've attached pdfs of the output to the tracker issue -
http://code.google.com/p/lilypond/issues/detail?id=1779

The problems i see:
note-head-chord - while i generally like the idea of suspended
noteheads being treated like 'decoration' (i.e. getting less space
between it and the barline than a normal, bare notehead would get), i
have an impression it's gone a bit too far in this case.
predefined-fretboards-transpose - chord diagrams look definately too
crowded now.

cheers,
Janek