[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Python 3 (was: 2.20 where are we?)

From: Matthew Peveler
Subject: Re: Python 3 (was: 2.20 where are we?)
Date: Mon, 23 Sep 2019 12:26:35 -0300

On Sat, Sep 21, 2019 at 5:52 AM Jonas Hahnfeld via lilypond-devel <
address@hidden> wrote:
> On top of that I've worked on the attached patches which brings the make
targets check / test and doc back to life with Python 3.7.4.

In applying your patches and running "make check", I encountered a couple
of errors in scripts/build/, which would be summed up as:
1. Python 2 old style classes had a default __cmp__ which would compare the
id() of the classes, and used implicitly for sort. Python 3 removed this,
but need to define a __lt__ method for sort compat.
2. attempting to open midi files as str files, though they are filled with
binary data (and python/ seems to expect binary in interacting with
the contents).

Please see the attached for small patches for these two things, and got
"make check" to run for me using Python 3.7.4 as well.


Attachment: 0001-add-__lt__-method-for-py2-old-style-class-sort-compa.patch
Description: Binary data

Attachment: 0002-read-midi-files-as-binary.patch
Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]