[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Python 3 (was: 2.20 where are we?)

From: Matthew Peveler
Subject: Re: Python 3 (was: 2.20 where are we?)
Date: Fri, 27 Sep 2019 17:34:44 -0300

You are right, that was added in my original debug effort. Attached is the
second patch without the added print. It looks like the files are getting
stored as `.bin` files, though are just plain text when you open them. If
someone could explain to me the proper way to attach patches here (or maybe
it's just gmail being funny?), I would appreciate it.

I'll have another email later on with patches for having this branch run
under both python2.7 & 3 as the necessary backport efforts were not really
all that extravagant with just a handful of shims around the changes you
noted in long vs int, unicode vs str, StringIO vs io, vs
iter.__next__, reload, xrange vs range. The primary thing missing is making
the stepmake/stepmake/python-module-*.make files work for the range of
versions, but I'm afraid that is out of my wheel house of ability.


On Thu, Sep 26, 2019 at 6:03 AM Jonas Hahnfeld <address@hidden> wrote:

> Am Montag, den 23.09.2019, 12:26 -0300 schrieb Matthew Peveler:
> > On Sat, Sep 21, 2019 at 5:52 AM Jonas Hahnfeld via lilypond-devel <
> address@hidden> wrote:
> > > On top of that I've worked on the attached patches which brings the
> make targets check / test and doc back to life with Python 3.7.4.
> >
> > In applying your patches and running "make check", I encountered a
> couple of errors in scripts/build/, which would be summed
> up as:
> >
> > 1. Python 2 old style classes had a default __cmp__ which would compare
> the id() of the classes, and used implicitly for sort. Python 3 removed
> this, but need to define a __lt__ method for sort compat.
> > 2. attempting to open midi files as str files, though they are filled
> with binary data (and python/ seems to expect binary in interacting
> with the contents).
> >
> > Please see the attached for small patches for these two things, and got
> "make check" to run for me using Python 3.7.4 as well.
> >
> > Regards,
> > Matt
> Ha, I already wondered why there are two targets check and test that
> both ran into the same issues (when I started). Turns out, the target
> "check" runs "test" but not the other way around, and I only verified
> that "test" works in the end...
> The patches make sense to me and also work on my system. You should
> probably remove the print() statement in the second patch, though.
> Thanks,
> Jonas

Description: Source code patch

reply via email to

[Prev in Thread] Current Thread [Next in Thread]