[Phpgroupware-developers] infinite loop in mssql code

[Bradley Bell]

If a query fails w/mssql, it goes into an infinite loop, as show below:

Warning: Sybase: Server message: There is already an object named
'phpgw_testrights' in the database. (severity 16, procedure N/A) in
/var/www/phpgroupware/phpgwapi/inc/class.db_mssql.inc.php on line 92

Warning: Sybase: Server message: The ROLLBACK TRANSACTION request has no
corresponding BEGIN TRANSACTION. (severity 16, procedure N/A)
in /var/www/phpgroupware/phpgwapi/inc/class.db_mssql.inc.php on line 92

Warning: Sybase: Server message: The ROLLBACK TRANSACTION request has no
corresponding BEGIN TRANSACTION. (severity 16, procedure N/A)
in /var/www/phpgroupware/phpgwapi/inc/class.db_mssql.inc.php on line 92

etc.

This is because:
$this->query() is called with a "bad" query, so it calls:
$this->halt(), which calls:
$this->unlock(), which calls:
$this->transaction_commit(), which calls:
$this->query() with another query doomed to fail...

Any ideas?

-brad

-- 
Bradley Bell
Computer Support Analyst
University of Washington
Classroom Support Services