[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 44/45] target/arm: Add allocation tag storage for system m
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v8 44/45] target/arm: Add allocation tag storage for system mode |
|
Date: |
Thu, 25 Jun 2020 15:16:27 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/25/20 10:09 AM, Peter Maydell wrote:
>>> Comment says we're checking a memory attribute, but the code
>>> is checking for TLB_MMIO, which isn't the same thing.
>>
>> Comment is not trying to allude to Normal vs Device, but "ram" vs "mmio" in
>> the
>> qemu sense.
>
> Oh, I see: maybe "if not backed by host RAM, then" ? I tend to
> assume "normal memory" means "Normal memory" :-)
Sure, changed. Also noticed two more places where calling via mte_probe1
should not fault.
r~
- [PATCH v8 41/45] target/arm: Always pass cacheattr to get_phys_addr, (continued)
[PATCH v8 45/45] target/arm: Enable MTE, Richard Henderson, 2020/06/23
Re: [PATCH v8 00/45] target/arm: Implement ARMv8.5-MemTag, system mode, Derrick McKee, 2020/06/23
Re: [PATCH v8 00/45] target/arm: Implement ARMv8.5-MemTag, system mode, no-reply, 2020/06/23
Re: [PATCH v8 00/45] target/arm: Implement ARMv8.5-MemTag, system mode, Peter Maydell, 2020/06/25