Re: [PATCH v2 08/43] hw/ide/piix: Introduce TYPE_ macros for PIIX IDE controllers

[Philippe Mathieu-Daudé]

On 22/10/22 17:04, Bernhard Beschow wrote:
> Suggested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
>   hw/i386/pc_piix.c     | 3 ++-
>   hw/ide/piix.c         | 5 +++--
>   hw/isa/piix4.c        | 3 ++-
>   include/hw/ide/piix.h | 7 +++++++
>   4 files changed, 14 insertions(+), 4 deletions(-)
>   create mode 100644 include/hw/ide/piix.h

> diff --git a/include/hw/ide/piix.h b/include/hw/ide/piix.h
> new file mode 100644
> index 0000000000..ef3ef3d62d
> --- /dev/null
> +++ b/include/hw/ide/piix.h
> @@ -0,0 +1,7 @@
> +#ifndef HW_IDE_PIIX_H
> +#define HW_IDE_PIIX_H
> +
> +#define TYPE_PIIX3_IDE "piix3-ide"
> +#define TYPE_PIIX4_IDE "piix4-ide"

I'd have added that to include/hw/southbridge/piix.h, but I
understand some machines want to include parts of PIIX, so:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>