|
From: | Avi Kivity |
Subject: | [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2) |
Date: | Sun, 10 Feb 2008 12:48:15 +0200 |
User-agent: | Thunderbird 2.0.0.9 (X11/20071115) |
Izik Eidus wrote:
Do you recall what this change fixed? As Paul pointed out in IRC, using the host type here doesn't really fix the problem (target_ulong would be more appropriate). However, we're both curious what problem it's actually fixing since sign extending the int should just work.Index: qemu/cpu-all.h =================================================================== --- qemu.orig/cpu-all.h 2008-02-01 15:24:45.000000000 -0600 +++ qemu/cpu-all.h 2008-02-01 15:28:48.000000000 -0600 @@ -695,7 +695,7 @@/* page related stuff */ -#define TARGET_PAGE_SIZE (1 << TARGET_PAGE_BITS)+#define TARGET_PAGE_SIZE (1ul << TARGET_PAGE_BITS) #define TARGET_PAGE_MASK ~(TARGET_PAGE_SIZE - 1) #define TARGET_PAGE_ALIGN(addr) (((addr) + TARGET_PAGE_SIZE - 1) & TARGET_PAGE_MASKok the commit say: kvm: qemu: change the type of the various page masks to unsigned longprevents truncation with >=4GB of guest physical memoryas far as i remember it was used to address something with cpu_physical_memory_rw() probably related to &TARGET_PAGE_SIZE or ~TARGET_PAGE_SIZE, the fact is that i dont know if it ever fixed anything
It fixes TARGET_PAGE_MASK, defined one line downscreen. I agree it should be changed to ((target_ulong)1 << TARGET_PAGE_BITS).
-- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |