[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 1.1 02/22] block: another bdrv_append fix

From: Paolo Bonzini
Subject: [Qemu-devel] [PATCH 1.1 02/22] block: another bdrv_append fix
Date: Tue, 8 May 2012 16:51:42 +0200

bdrv_append must also copy open_flags to the top, because the snapshot
has BDRV_O_NO_BACKING set.  This causes interesting results if you
later use drive-reopen (not upstream) to reopen the image, and lose
the backing file in the process.

Signed-off-by: Paolo Bonzini <address@hidden>
 block.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/block.c b/block.c
index 87600a5..6dc0d44 100644
--- a/block.c
+++ b/block.c
@@ -977,6 +977,7 @@ void bdrv_append(BlockDriverState *bs_new, BlockDriverState 
     tmp = *bs_new;
     /* there are some fields that need to stay on the top layer: */
+    tmp.open_flags        = bs_top->open_flags;
     /* dev info */
     tmp.dev_ops           = bs_top->dev_ops;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]