|
From: | Kevin Wolf |
Subject: | Re: [Qemu-devel] [PATCH 1.1 04/22] block: fully delete bs->file when closing |
Date: | Wed, 09 May 2012 14:22:21 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Am 08.05.2012 16:51, schrieb Paolo Bonzini: > We are reusing bs->file across close/open, which may not cause any > known bugs but is a recipe for trouble. Prefer bdrv_delete, and > enjoy the new invariant in the implementation of bdrv_delete. > > Signed-off-by: Paolo Bonzini <address@hidden> I think bs->file is changed during bdrv_open() for all block drivers that make use of it. We do however leak the old bs->file then. Kevin
[Prev in Thread] | Current Thread | [Next in Thread] |