[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable |
Date: |
Thu, 06 Sep 2012 12:47:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120825 Thunderbird/10.0.7 |
On 09/06/12 09:48, Peter Maydell wrote:
> On 6 September 2012 08:42, Gerd Hoffmann <address@hidden> wrote:
>> @@ -789,6 +790,13 @@ static int serial_isa_initfn(ISADevice *dev)
>> isa->isairq = isa_serial_irq[isa->index];
>> index++;
>>
>> + if (isa->iobase == 0x3f8) {
>> + s->reason = QEMU_WAKEUP_REASON_GPE_a;
>> + s->wakeup = 1;
>> + } else {
>> + s->reason = QEMU_WAKEUP_REASON_OTHER;
>> + }
>> +
>
> It seems a bit odd that this is done in the ISA serial model
> itself and not by the next level up wiring up some output
> of the ISA serial device to some appropriate input...
Suggestions how to do that are welcome. Preferably some which don't
break on 'qemu -nodefault -device isa-serial,chardev=foo'.
cheers,
Gerd
- [Qemu-devel] [PULL 0/4] wakeup: make wakeup events guest-configurable, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Gerd Hoffmann, 2012/09/06
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Peter Maydell, 2012/09/06
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Blue Swirl, 2012/09/08
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Paolo Bonzini, 2012/09/08
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Anthony Liguori, 2012/09/10
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Paolo Bonzini, 2012/09/10
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Peter Maydell, 2012/09/10
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Anthony Liguori, 2012/09/10
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Gerd Hoffmann, 2012/09/10
[Qemu-devel] [PATCH 1/4] wakeup: add acpi gpe wakeup reasons, Gerd Hoffmann, 2012/09/06
[Qemu-devel] [PATCH 4/4] wakeup: uhci support, Gerd Hoffmann, 2012/09/06
[Qemu-devel] [PATCH 2/4] wakeup: make ps/2 configurable, Gerd Hoffmann, 2012/09/06