[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable |
Date: |
Mon, 10 Sep 2012 12:19:23 -0500 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Peter Maydell <address@hidden> writes:
> On 10 September 2012 17:07, Paolo Bonzini <address@hidden> wrote:
>> Il 10/09/2012 18:02, Anthony Liguori ha scritto:
>>> IOW, shouldn't it be something more like, SerialState exports a qemu_irq
>>> and then the machine code decides whether to route that irq to a call to
>>> qemu_system_wakeup(). Then depending on whether this is coming from
>>> serial[1], determines which reason is used.
>>
>> But the only way to do it, that works for -device, is to look at the
>> SerialState's iobase.
>
> This just says that -device is broken (which we kinda already knew
> :-))
There are opposing forces here.
libvirt wants to use -device because we don't provide a way for machine
creates devices to be configurable. We can't fix this until we separate
realization from initialization. After that point, libvirt could
address properties on machine-created devices directly.
I think the best short term solution is to have a post '-device' handler
in machines that could be used to make the appropriate connections.
Power et al. need this anyway for dealing with device tree creation so
it seems to be inevitable.
Regards,
Anthony Liguori
>
> -- PMM
- [Qemu-devel] [PULL 0/4] wakeup: make wakeup events guest-configurable, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Gerd Hoffmann, 2012/09/06
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Peter Maydell, 2012/09/06
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Gerd Hoffmann, 2012/09/06
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Blue Swirl, 2012/09/08
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Paolo Bonzini, 2012/09/08
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Anthony Liguori, 2012/09/10
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Paolo Bonzini, 2012/09/10
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Peter Maydell, 2012/09/10
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable,
Anthony Liguori <=
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Gerd Hoffmann, 2012/09/10
[Qemu-devel] [PATCH 1/4] wakeup: add acpi gpe wakeup reasons, Gerd Hoffmann, 2012/09/06
[Qemu-devel] [PATCH 4/4] wakeup: uhci support, Gerd Hoffmann, 2012/09/06
[Qemu-devel] [PATCH 2/4] wakeup: make ps/2 configurable, Gerd Hoffmann, 2012/09/06