[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable |
Date: |
Mon, 10 Sep 2012 07:47:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120825 Thunderbird/10.0.7 |
Hi,
>>> It seems a bit odd that this is done in the ISA serial model
>>> itself and not by the next level up wiring up some output
>>> of the ISA serial device to some appropriate input...
>>
>> Suggestions how to do that are welcome. Preferably some which don't
>> break on 'qemu -nodefault -device isa-serial,chardev=foo'.
>
> Add a qdev property?
And offload it to the user / management tool to get that correct? Don't
think this is a good idea.
> The base address check can't be correct, the
> serial device could be the only one in the board and wired to wakeup
> but still use a different iobase.
We might want to add a check for TARGET_I386, but for x86 it actually
_is_ correct as this matches the acpi dsdt information.
> One way could be to check if chr == serial_hds[0] or rather, pass the
> wakeup reason code from board level based on this check.
Wouldn't work.
cheers,
Gerd
- [Qemu-devel] [PULL 0/4] wakeup: make wakeup events guest-configurable, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Gerd Hoffmann, 2012/09/06
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Peter Maydell, 2012/09/06
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Gerd Hoffmann, 2012/09/06
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Blue Swirl, 2012/09/08
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Paolo Bonzini, 2012/09/08
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Anthony Liguori, 2012/09/10
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Paolo Bonzini, 2012/09/10
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Peter Maydell, 2012/09/10
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable, Anthony Liguori, 2012/09/10
- Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable,
Gerd Hoffmann <=
[Qemu-devel] [PATCH 1/4] wakeup: add acpi gpe wakeup reasons, Gerd Hoffmann, 2012/09/06
[Qemu-devel] [PATCH 4/4] wakeup: uhci support, Gerd Hoffmann, 2012/09/06
[Qemu-devel] [PATCH 2/4] wakeup: make ps/2 configurable, Gerd Hoffmann, 2012/09/06