Re: [Qemu-devel] [PATCH 19/20] tcg: Remove gen_intermediate_code_pc

[Peter Maydell]

On 2 September 2015 at 06:52, Richard Henderson <address@hidden> wrote:
> It's no longer used, so tidy up everything reached by it.
> This includes the gen_opc_* arrays, the search_pc parameter
> and the inline gen_intermediate_code_internal functions.

> @@ -11254,10 +11248,9 @@ static inline void 
> gen_intermediate_code_internal(ARMCPU *cpu,
>       * (3) if we leave the TB unexpectedly (eg a data abort on a load)
>       * then the CPUARMState will be wrong and we need to reset it.
>       * This is handled in the same way as restoration of the
> -     * PC in these situations: we will be called again with search_pc=1
> -     * and generate a mapping of the condexec bits for each PC in
> -     * gen_opc_condexec_bits[]. restore_state_to_opc() then uses
> -     * this to restore the condexec bits.
> +     * PC in these situations; the saved mapping of the condexec bits
> +     * for each PC which restore_state_to_opc() then uses this to
> +     * restore the condexec bits.

The grammar here is a bit flaky. Try

> +     * PC in these situations; we save the value of the condexec bits
> +     * for each PC via tcg_gen_insn_start(), and restore_state_to_opc()
> +     * then uses this to restore them after an exception.

Otherwise

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM