qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 44/76] target/mips: Add handling of branch de


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v5 44/76] target/mips: Add handling of branch delay slots for nanoMIPS
Date: Tue, 31 Jul 2018 15:03:13 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 07/30/2018 12:12 PM, Aleksandar Markovic wrote:
> -        int lowbit = !!(ctx->hflags & MIPS_HFLAG_M16);
> +        int lowbit = ctx->has_isa_mode && !!(ctx->hflags & MIPS_HFLAG_M16);

I believe I asked why M16 is set for nanoMIPS at all.

You go out of your way to ignore it in lots of places,
and avoid it being cleared in others.  And I noted some
places where it seemed to have been forgotten to be ignored.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]