[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in p
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak |
Date: |
Tue, 14 Aug 2018 15:05:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 14/08/2018 14:57, Peter Maydell wrote:
> On 14 August 2018 at 13:56, Paolo Bonzini <address@hidden> wrote:
>> On 14/08/2018 14:06, Peter Maydell wrote:
>>> What about the boards that use the serial.c code but do not
>>> have PCI, ISA or a superio chip? That is, all the boards/devices
>>> that call serial_mm_init() directly to create a memory-mapped
>>> 16550.
>>
>> They just add
>>
>> CONFIG_SERIAL=y
>>
>> to the .mak file.
>
> ...but the patch that has kicked off this thread is *removing*
> CONFIG_SERIAL=y from the various .mak files...
Probably because they were including pci.mak. Indeed CONFIG_SERIAL=y
should remain in the
ARM/HPPA/Microblaze/MIPS/Mozie/NiOS2/OpenRISC/PPC/RiscV/SH/SPARC64/Xtensa
.mak files.
Another possibility would be to split .mak files per-machine, and
include the per-machine file in the toplevel.
Thanks,
Paolo
- [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, (continued)
- [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Juan Quintela, 2018/08/08
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Thomas Huth, 2018/08/08
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Paolo Bonzini, 2018/08/10
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Juan Quintela, 2018/08/14
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Paolo Bonzini, 2018/08/14
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Peter Maydell, 2018/08/14
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Paolo Bonzini, 2018/08/14
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Peter Maydell, 2018/08/14
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak, Juan Quintela, 2018/08/14
[Qemu-devel] [PATCH v2 03/22] check: Use land/lor when possible, Juan Quintela, 2018/08/08
[Qemu-devel] [PATCH v2 04/22] check: Only test isa-testdev when it is compiled in, Juan Quintela, 2018/08/08
[Qemu-devel] [PATCH v2 01/22] configure: We don't want to clean configuration files, Juan Quintela, 2018/08/08