Re: [Qemu-devel] [PATCH 3/9] iotests: Fix 232 for LUKS

[Max Reitz]

On 29.01.19 22:26, John Snow wrote:
> 
> 
> On 1/23/19 9:46 AM, Max Reitz wrote:
>> With IMGOPTSSYNTAX, $TEST_IMG is useless for this test (it only tests
>> the file-posix protocol driver).  Therefore, if $TEST_IMG_FILE is set,
>> use that instead.
>>
>> Because this test requires the file protocol, $TEST_IMG_FILE will always
>> be set if $IMGOPTSSYNTAX is true.
>>
>> Signed-off-by: Max Reitz <address@hidden>
> 
> This keeps biting us. Or at least, it bit me once and then it has bitten
> someone else. It's not obvious that you need to accommodate this when
> writing a new test.

No, it isn't. :-)

But I think at least me running ./check -luks from time to time should
be sufficient, usually.  It's just that I had basically given up on a
clean iotests run for a month or two now...

Max

signature.asc
Description: OpenPGP digital signature