[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/6] Acceptance Tests: log information when creating QEMUMach

From: Wainer dos Santos Moschetta
Subject: Re: [PATCH 4/6] Acceptance Tests: log information when creating QEMUMachine
Date: Mon, 15 Feb 2021 16:15:23 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 2/11/21 7:01 PM, Cleber Rosa wrote:
Including its base temporary directory, given that information useful
for debugging can be put there.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
  tests/acceptance/avocado_qemu/__init__.py | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

diff --git a/tests/acceptance/avocado_qemu/__init__.py 
index b7ab836455..94b78fd7c8 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -170,10 +170,12 @@ class Test(avocado.Test):
          if self.qemu_bin is None:
              self.cancel("No QEMU binary defined or found in the build tree")
- def _new_vm(self, *args):
+    def _new_vm(self, name, *args):
          self._sd = tempfile.TemporaryDirectory(prefix="avo_qemu_sock_")
          vm = QEMUMachine(self.qemu_bin, base_temp_dir=self.workdir,
+        self.log.debug('QEMUMachine "%s" created', name)
+        self.log.debug('QEMUMachine "%s" temp_dir: %s', name, vm.temp_dir)
          if args:
          return vm
@@ -186,7 +188,7 @@ class Test(avocado.Test):
          if not name:
              name = str(uuid.uuid4())
          if self._vms.get(name) is None:
-            self._vms[name] = self._new_vm(*args)
+            self._vms[name] = self._new_vm(name, *args)
              if self.machine is not None:
          return self._vms[name]

reply via email to

[Prev in Thread] Current Thread [Next in Thread]