[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 25/28] target/mips: Fix gen_mxu_s32ldd_s32lddr
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 25/28] target/mips: Fix gen_mxu_s32ldd_s32lddr |
Date: |
Mon, 21 Jun 2021 22:59:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
Cc'ing Craig
On 6/14/21 10:37 AM, Richard Henderson wrote:
> There were two bugs here: (1) the required endianness was
> not present in the MemOp, and (2) we were not providing a
> zero-extended input to the bswap as semantics required.
>
> The best fix is to fold the bswap into the memory operation,
> producing the desired result directly.
>
> Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/mips/tcg/mxu_translate.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/target/mips/tcg/mxu_translate.c b/target/mips/tcg/mxu_translate.c
> index c12cf78df7..f4356432c7 100644
> --- a/target/mips/tcg/mxu_translate.c
> +++ b/target/mips/tcg/mxu_translate.c
> @@ -857,12 +857,8 @@ static void gen_mxu_s32ldd_s32lddr(DisasContext *ctx)
> tcg_gen_ori_tl(t1, t1, 0xFFFFF000);
> }
> tcg_gen_add_tl(t1, t0, t1);
> - tcg_gen_qemu_ld_tl(t1, t1, ctx->mem_idx, MO_SL);
> + tcg_gen_qemu_ld_tl(t1, t1, ctx->mem_idx, MO_TESL ^ (sel * MO_BSWAP));
>
> - if (sel == 1) {
> - /* S32LDDR */
> - tcg_gen_bswap32_tl(t1, t1, TCG_BSWAP_IZ | TCG_BSWAP_OZ);
> - }
> gen_store_mxu_gpr(t1, XRa);
>
> tcg_temp_free(t0);
>
Acked-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH 16/28] tcg: Handle new bswap flags during optimize, (continued)
- [PATCH 16/28] tcg: Handle new bswap flags during optimize, Richard Henderson, 2021/06/14
- [PATCH 15/28] tcg/tci: Support bswap flags, Richard Henderson, 2021/06/14
- [PATCH 20/28] target/arm: Improve REV32, Richard Henderson, 2021/06/14
- [PATCH 19/28] tcg: Make use of bswap flags in tcg_gen_qemu_st_*, Richard Henderson, 2021/06/14
- [PATCH 25/28] target/mips: Fix gen_mxu_s32ldd_s32lddr, Richard Henderson, 2021/06/14
- Re: [PATCH 25/28] target/mips: Fix gen_mxu_s32ldd_s32lddr,
Philippe Mathieu-Daudé <=
- [PATCH 27/28] tcg/aarch64: Unset TCG_TARGET_HAS_MEMORY_BSWAP, Richard Henderson, 2021/06/14
- [PATCH 12/28] tcg/s390: Support bswap flags, Richard Henderson, 2021/06/14
- [PATCH 21/28] target/arm: Improve vector REV, Richard Henderson, 2021/06/14
- [PATCH 23/28] target/i386: Improve bswap translation, Richard Henderson, 2021/06/14
- [PATCH 24/28] target/sh4: Improve swap.b translation, Richard Henderson, 2021/06/14