[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 16/28] tcg: Handle new bswap flags during optimize
From: |
Peter Maydell |
Subject: |
Re: [PATCH 16/28] tcg: Handle new bswap flags during optimize |
Date: |
Mon, 21 Jun 2021 15:47:55 +0100 |
On Mon, 14 Jun 2021 at 09:45, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Notice when the input is known to be zero-extended and force
> the TCG_BSWAP_IZ flag on. Honor the TCG_BSWAP_OS bit during
> constant folding. Propagate the input to the output mask.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/optimize.c | 56 +++++++++++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 51 insertions(+), 5 deletions(-)
Not really familiar with the TCG optimizer internals, so review
from somebody who is would be useful, but this looks plausible:
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH 17/28] tcg: Add flags argument to tcg_gen_bswap16_*, tcg_gen_bswap32_i64, (continued)
- [PATCH 17/28] tcg: Add flags argument to tcg_gen_bswap16_*, tcg_gen_bswap32_i64, Richard Henderson, 2021/06/14
- [PATCH 18/28] tcg: Make use of bswap flags in tcg_gen_qemu_ld_*, Richard Henderson, 2021/06/14
- [PATCH 09/28] tcg/ppc: Split out tcg_out_bswap64, Richard Henderson, 2021/06/14
- [PATCH 11/28] tcg/ppc: Use power10 byte-reverse instructions, Richard Henderson, 2021/06/14
- [PATCH 16/28] tcg: Handle new bswap flags during optimize, Richard Henderson, 2021/06/14
- Re: [PATCH 16/28] tcg: Handle new bswap flags during optimize,
Peter Maydell <=
- [PATCH 15/28] tcg/tci: Support bswap flags, Richard Henderson, 2021/06/14
- [PATCH 20/28] target/arm: Improve REV32, Richard Henderson, 2021/06/14
- [PATCH 19/28] tcg: Make use of bswap flags in tcg_gen_qemu_st_*, Richard Henderson, 2021/06/14
- [PATCH 25/28] target/mips: Fix gen_mxu_s32ldd_s32lddr, Richard Henderson, 2021/06/14
- [PATCH 27/28] tcg/aarch64: Unset TCG_TARGET_HAS_MEMORY_BSWAP, Richard Henderson, 2021/06/14