qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] hw/char/renesas_sci: Add fifo buffer to backend interfac


From: Thomas Huth
Subject: Re: [PATCH 1/2] hw/char/renesas_sci: Add fifo buffer to backend interface.
Date: Tue, 1 Feb 2022 07:48:58 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 31/01/2022 10.42, Yoshinori Sato wrote:
SCI does not have a fifo, it is necessary to send and receive
  at a bit rate speed.
But, qemu's chardev backend does not have a buffer,
  so it sends received data continuously.
By buffering the received data with the FIFO, continuous
  received data can be received.

 Hi!

If you describe it like this, it sounds like you're now emulating a buffer that is not there with real hardware? Is that really what you want here, i.e. wouldn't this hide problems with the real hardware that are mitigated in QEMU with this buffer?

Anyway, please use scripts/get_maintainer.pl to get a list of people who should be put on CC:, otherwise your patches might get lost in the high traffic of the mailing list.

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]