[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by d
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default |
Date: |
Tue, 17 Jan 2023 12:22:35 +0000 |
On Tue, 17 Jan 2023 at 12:02, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Tue, Jan 17, 2023 at 11:16:32AM +0000, Peter Maydell wrote:
> > On Tue, 17 Jan 2023 at 10:44, Daniel P. Berrangé <berrange@redhat.com>
> > wrote:
> > > Something random that looks like bad text data
> > >
> > > ▶ 166/619 /ptimer/oneshot
> > > policy=no_immediate_����������������������������������������������������������������...snip....�������������
> >
> > I don't understand this one. The string comes from
> > tests/unit/ptimer-test.c:add_ptimer_tests() but that
> > code creates the test string using g_strlcat() and
> > g_strdup_printf(), so I don't see how it could end
> > up being junk, especially not at that point in
> > the string. I guess it's possible something else in
> > the test is managing to corrupt the g_test test name
> > strings?
>
> Actually it looks like something else spewing ����������
> a to stderr, and this getting intermixed with stdout from the
> test suite. The test case name isn't corrupt, as I see the
> remaining "reload,..." bit that jouins with 'policy=no_immediate_"
>
> Wonder what's responsible for this garbage on stderr...
Mmm.
Also I notice that we could save some output if we can
fix whatever it is that's producing out-of-spec TAP
format and causing this to be printed for every test:
Unknown TAP version. The first line MUST be `TAP version <int>`.
Assuming version 12.
-- PMM
- Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default, Philippe Mathieu-Daudé, 2023/01/16
- Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default, Peter Maydell, 2023/01/16
- Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default, Peter Maydell, 2023/01/17
- Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default, Thomas Huth, 2023/01/17
- Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default, Daniel P . Berrangé, 2023/01/17
- Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default, Peter Maydell, 2023/01/17
- Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default, Daniel P . Berrangé, 2023/01/17
- Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default,
Peter Maydell <=
- Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default, Daniel P . Berrangé, 2023/01/17
- Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default, Thomas Huth, 2023/01/18
- Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default, Daniel P . Berrangé, 2023/01/18
- float tests are too verbose (was: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default), Thomas Huth, 2023/01/18
- Re: float tests are too verbose (was: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default), Alex Bennée, 2023/01/18