Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

[Daniel P . Berrangé]

On Tue, Jan 17, 2023 at 12:22:35PM +0000, Peter Maydell wrote:
> On Tue, 17 Jan 2023 at 12:02, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Tue, Jan 17, 2023 at 11:16:32AM +0000, Peter Maydell wrote:
> > > On Tue, 17 Jan 2023 at 10:44, Daniel P. Berrangé <berrange@redhat.com> 
> > > wrote:
> > > > Something random that looks like bad text data
> > > >
> > > > ▶ 166/619 /ptimer/oneshot 
> > > > policy=no_immediate_����������������������������������������������������������������...snip....�������������
> > >
> > > I don't understand this one. The string comes from
> > > tests/unit/ptimer-test.c:add_ptimer_tests() but that
> > > code creates the test string using g_strlcat() and
> > > g_strdup_printf(), so I don't see how it could end
> > > up being junk, especially not at that point in
> > > the string. I guess it's possible something else in
> > > the test is managing to corrupt the g_test test name
> > > strings?
> >
> > Actually it looks like something else spewing ����������
> > a to stderr, and this getting intermixed with stdout from the
> > test suite.  The test case name isn't corrupt, as I see the
> > remaining "reload,..." bit that jouins with 'policy=no_immediate_"
> >
> > Wonder what's responsible for this garbage on stderr...
> 
> Mmm.
> 
> Also I notice that we could save some output if we can
> fix whatever it is that's producing out-of-spec TAP
> format and causing this to be printed for every test:
> 
> Unknown TAP version. The first line MUST be `TAP version <int>`.
> Assuming version 12.

That's a meson bug caused by this misguided change

  https://github.com/mesonbuild/meson/pull/11186

and suggested to revert

  https://github.com/mesonbuild/meson/pull/11242

Though it seems the meson maintainer prefers their only patch:

  
https://github.com/eli-schwartz/meson/commit/f0928378d2246bcf8a81be35c44b1350a549d647

but that's not submitted for merge that I've found.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|