Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

[Daniel P . Berrangé]

On Wed, Jan 18, 2023 at 01:55:49PM +0100, Thomas Huth wrote:
> On 17/01/2023 11.44, Daniel P. Berrangé wrote:
> > On Tue, Jan 17, 2023 at 11:32:42AM +0100, Thomas Huth wrote:
> ...
> > > - Instead of doing "cat meson-logs/testlog.txt" in the CI
> > >    scripts, we switch to "tail -n 1000 meson-logs/testlog.txt"
> > >    instead
> > 
> > Tail requires that it has consumed the entire doc before it prints
> > anything. This in turn implies that the test suite has finished.
> > IOW, we'll get zero output if it hangs IIUC.
> 
> I was referring to the places where we are dumping the testlog.txt like this:
> 
>  make --output-sync -j`nproc` check
>    || { cat meson-logs/testlog.txt; exit 1; }
> 
> See .gitlab-ci.d/custom-runners/* or .gitlab-ci.d/windows.yml for example. I
> assume it should be ok to switch to "tail" instead of "cat" there?

Yes, it would be OK, bug lets make sure meson-logs/testlog.txt is included
as an artifact published by the job, so we can access the full set if
needed


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|