qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by d


From: Thomas Huth
Subject: Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default
Date: Wed, 18 Jan 2023 13:55:49 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 17/01/2023 11.44, Daniel P. Berrangé wrote:
On Tue, Jan 17, 2023 at 11:32:42AM +0100, Thomas Huth wrote:
...
- Instead of doing "cat meson-logs/testlog.txt" in the CI
   scripts, we switch to "tail -n 1000 meson-logs/testlog.txt"
   instead

Tail requires that it has consumed the entire doc before it prints
anything. This in turn implies that the test suite has finished.
IOW, we'll get zero output if it hangs IIUC.

I was referring to the places where we are dumping the testlog.txt like this:

 make --output-sync -j`nproc` check
   || { cat meson-logs/testlog.txt; exit 1; }

See .gitlab-ci.d/custom-runners/* or .gitlab-ci.d/windows.yml for example. I assume it should be ok to switch to "tail" instead of "cat" there?

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]